Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the settlement_service_type of dvp delivery when indexing #679

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Store the settlement_service_type of dvp delivery when indexing #679

merged 3 commits into from
Aug 20, 2024

Conversation

purplesmoke05
Copy link
Member

Close #674

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

Coverage

Coverage Report •
FileStmtsMissCoverMissing
indexer_dvp_delivery.py3293489%110–111, 117–119, 292, 305, 346–347, 367–368, 383, 396, 411–412, 427, 440, 471–472, 487, 500, 531–532, 547, 560, 575–576, 649, 831–832, 838–841
db
   idx_dvp_delivery.py42197%100
issuer
   settlement_issuer.py1551093%168, 296, 298, 434, 436, 444, 452, 460, 571–572
misc
   settlement_agent.py164298%218, 318
schema
   settlement.py1480100% 
TOTAL12886113191% 

Tests Skipped Failures Errors Time
1875 0 💤 0 ❌ 0 🔥 35m 47s ⏱️

@purplesmoke05 purplesmoke05 marked this pull request as ready for review August 20, 2024 04:33
@YoshihitoAso YoshihitoAso merged commit d735c4d into dev-24.9 Aug 20, 2024
@YoshihitoAso YoshihitoAso deleted the feature/#674 branch August 20, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshihitoAso YoshihitoAso YoshihitoAso approved these changes

Assignees

@purplesmoke05 purplesmoke05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Store the settlement_service_type of dvp delivery when processing index
2 participants
@purplesmoke05 @YoshihitoAso